feat(server): support single computer do schedule task by shirleyStorage · Pull Request #2676 · apache/hugegraph

shirleyStorage · 2024-10-11T16:32:29Z

Purpose of the PR

close [Bug] Can not delete vertex labels when use standalone mode and set server.role=computer #2675

Main Changes

Verifying these changes

Trivial rework / code cleanup without any test coverage. (No Need)
Already covered by existing tests, such as (please modify tests here).
Need tests and can be verified as follows:
- hugegraph basic operation test All tests have passed

Does this PR potentially affect the following parts?

Documentation Status

Doc - TODO
Doc - Done
Doc - No Need

Signed-off-by: shirley118146 <shirley118146@gmail.com>

shirleyStorage · 2024-10-12T02:05:35Z

@imbajin PTAL~

shirleyStorage · 2024-10-20T15:02:06Z

@imbajin I updated the test case to the PR description. PTAL ~~

shirleyStorage · 2024-10-20T15:05:10Z

@dosu how to rerun "HugeGraph-Server CI / build-server (hbase, 11)"

JackyYangPassion · 2024-10-22T14:44:44Z

@dosu how to rerun "HugeGraph-Server CI / build-server (hbase, 11)"

2024-10-22.22.40.08.mov

javeme

Thanks for your contribution.
Can I know in what scenario you need to do this?

javeme · 2024-10-27T12:40:52Z

+
+        boolean singleNode = !hasWorkerNode||computerNodeCount==1;
+        if (singleNode != this.onlySingleNode) {
+            LOG.info("Switch only_single_node 02 to {}", singleNode);


not sure 02 means what

javeme · 2024-10-27T12:41:33Z

+            }
+            if (server.role().master()) {
+                continue;
+            }else if (server.role().computer()){


add a space after '}', or remove 'else'

javeme · 2024-10-27T12:53:04Z

-        return this.selfNodeRole() != null && this.selfNodeRole().master();
+    public boolean selfIsMasterOrSingleComputer() {
+        boolean isMaster=this.selfNodeRole() != null && this.selfNodeRole().master();
+        boolean isSingleComputer=isStandAloneComputer();


expect spaces " = "

javeme · 2024-10-27T12:53:27Z

+        return this.selfNodeRole() != null && this.selfNodeRole().computer();
+    }
+
+    public boolean isStandAloneComputer(){


unused method?

Tsukilc · 2025-11-10T05:01:03Z

Hello, I'm trying to disable the server-role option（https://github.com/hugegraph/hugegraph/pull/85）. I'd like to ask what blocked this pr merge before?

Copilot

Pull request overview

This PR aims to let a standalone computer role node schedule and execute tasks in HugeGraph’s task scheduling flow.

Changes:

Allows master checks to pass for selfIsMasterOrSingleComputer().
Adds standalone-computer detection in ServerInfoManager.
Refreshes single-node state during scheduler heartbeat flow.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/TaskManager.java`	Updates scheduling gate to include standalone computer nodes.
`hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/StandardTaskScheduler.java`	Allows standard task scheduling/cancel master checks for standalone computer nodes.
`hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/ServerInfoManager.java`	Adds standalone-computer detection and recalculates single-node state.
`hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/DistributedTaskScheduler.java`	Updates distributed scheduler requirement checks for standalone computer nodes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    public boolean selfIsMasterOrSingleComputer() {
+        boolean isMaster=this.selfNodeRole() != null && this.selfNodeRole().master();
+        boolean isSingleComputer=isStandAloneComputer();
+        return isMaster||isSingleComputer;
+    }
+
+    public boolean selfIsComputer() {
+        return this.selfNodeRole() != null && this.selfNodeRole().computer();
+    }
+
+    public boolean isStandAloneComputer(){
+        return this.onlySingleNode() && this.selfIsComputer();


+    protected synchronized void updateIsSingleNode(){
+        Collection<HugeServerInfo> servers=this.allServerInfos();
+        boolean hasWorkerNode = false;
+        long now = DateUtil.now().getTime();
+        int computerNodeCount=0;
+
+        // Iterate servers to find suitable one
+        for (HugeServerInfo server : servers) {
+            if (!server.alive()) {
+                continue;
+            }
+            if (server.role().master()) {
+                continue;
+            }else if (server.role().computer()){
+                computerNodeCount++;
+            }
+            hasWorkerNode = true;
+        }
+
+        boolean singleNode = !hasWorkerNode||computerNodeCount==1;
+        if (singleNode != this.onlySingleNode) {
+            LOG.info("Switch only_single_node 02 to {}", singleNode);
+            this.onlySingleNode = singleNode;
+        }
+    }


imbajin

I found two remaining behavior issues around standalone computer scheduling. The existing current-head Copilot comments for checkstyle and the mixed worker/computer onlySingleNode case are valid, so I added +1 reactions there instead of duplicating them.

2 CI/status checks failed on the latest head; please check the failed jobs 🔗 https://github.com/apache/hugegraph/actions/runs/16592586432/job/46931607687.

imbajin · 2026-05-29T09:59:19Z

                // Update server heartbeat
                serverManager.heartbeat();

+                serverManager.updateIsSingleNode();


‼️ onlySingleNode is first refreshed here, but selfIsMasterOrSingleComputer() is already used by StandardTaskScheduler.checkOnMasterNode() before this periodic loop runs. Since TaskManager starts this loop with a 10 * SCHEDULE_PERIOD initial delay, a standalone server.role=computer node can still reject the first task request after startup with Can't schedule task on non-master server. Please initialize this state during server-info bootstrap, or compute the standalone-computer condition on demand instead of waiting for the background scheduler.

imbajin · 2026-05-29T09:59:19Z

            return;
        }
-        if (this.selfIsMaster()) {
+        if (this.selfIsMasterOrSingleComputer()) {


‼️ This changes the recovery behavior for standalone computer nodes when their own ServerInfo entry is missing. Before this patch, non-master nodes recreated the missing record locally via saveServerInfo(...); after this change, a standalone computer returns here and waits for re-init like a master. In standalone server.role=computer mode there is no master to recreate that row, so once the server-info vertex is lost the node cannot recover itself anymore. Please keep the local re-save path for standalone computers, or add a dedicated re-init path for them.

imbajin

I added +1 reactions to the existing Copilot comments that already cover the checkstyle breakage and the single-computer misclassification bug. One additional gap remains around missing coverage.

2 CI/status checks failed; please check the failed jobs: 🔗 https://github.com/apache/hugegraph/actions/runs/16592586432/job/46931607687

imbajin · 2026-05-29T09:59:35Z

        return !this.closed && this.graph.started() && this.graph.initialized();
    }

+    protected synchronized void updateIsSingleNode(){


This scheduler role change needs automated coverage. The PR changes when a computer node can pass master-only scheduling checks and recalculates onlySingleNode, but no test files are changed, so the standalone-computer path and the master + worker + single-computer case are unguarded. Please add tests that cover a single computer node scheduling a task and a mixed cluster where one computer node must not make the whole deployment behave as single-node.

imbajin

One additional standalone-computer scheduling gap remains in the distributed scheduler path.

2 CI/status checks failed on the latest head; please check the failed jobs 🔗 https://github.com/apache/hugegraph/actions/runs/16592586432/job/46931607687.

imbajin · 2026-05-29T10:04:59Z

    @Override
    public void checkRequirement(String op) {
-        if (!this.serverManager().selfIsMaster()) {
+        if (!this.serverManager().selfIsMasterOrSingleComputer()) {


DistributedTaskScheduler now also depends on selfIsMasterOrSingleComputer(), but this scheduler never refreshes the new onlySingleNode flag. TaskManager.scheduleOrExecuteJobForGraph() only calls updateIsSingleNode() inside the StandardTaskScheduler branch, while each scheduler owns its own ServerInfoManager initialized with onlySingleNode = false. In scheduler.type=distributed, a standalone server.role=computer node therefore still fails this requirement check permanently instead of passing as a standalone computer.

shirley118146 added 3 commits October 12, 2024 00:31

support computer do schedule

3e964a0

Signed-off-by: shirley118146 <shirley118146@gmail.com>

update single node

9159a49

Signed-off-by: shirley118146 <shirley118146@gmail.com>

code format

62a21f4

Signed-off-by: shirley118146 <shirley118146@gmail.com>

shirleyStorage changed the title ~~[DNM] Support computer do schedule task~~ Support computer do schedule task Oct 11, 2024

shirleyStorage marked this pull request as ready for review October 11, 2024 17:45

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New feature labels Oct 11, 2024

shirleyStorage changed the title ~~Support computer do schedule task~~ Support single computer do schedule task Oct 12, 2024

imbajin requested a review from zyxxoo October 12, 2024 08:43

Merge branch 'apache:master' into yaojingyi/computer_do_sche

9fb1daf

javeme reviewed Oct 27, 2024

View reviewed changes

imbajin changed the title ~~Support single computer do schedule task~~ feat: support single computer do schedule task Oct 28, 2024

imbajin changed the title ~~feat: support single computer do schedule task~~ feat(server): support single computer do schedule task Oct 28, 2024

Merge branch 'master' into yaojingyi/computer_do_sche

bcbb3b6

imbajin requested a review from Copilot May 29, 2026 09:38

Copilot started reviewing on behalf of imbajin May 29, 2026 09:38 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

imbajin reviewed May 29, 2026

View reviewed changes

Conversation

shirleyStorage commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of the PR

Main Changes

Verifying these changes

Does this PR potentially affect the following parts?

Documentation Status

Uh oh!

shirleyStorage commented Oct 12, 2024

Uh oh!

shirleyStorage commented Oct 20, 2024

Uh oh!

shirleyStorage commented Oct 20, 2024

Uh oh!

JackyYangPassion commented Oct 22, 2024

Uh oh!

javeme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tsukilc commented Nov 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

imbajin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imbajin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imbajin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shirleyStorage commented Oct 11, 2024 •

edited

Loading