chore(docker): remove tmp volume mounts after image update#2976
Conversation
|
THX, the latest images in DockerHub already updated: (Also updated the introduction info) |
There was a problem hiding this comment.
Pull request overview
Cleans up Docker Compose configurations by removing now-unnecessary entrypoint overrides and bind-mounted helper scripts after the corresponding Docker images were updated to include the new entrypoints directly.
Changes:
- Removed temporary
entrypoint:overrides from single-node and 3x3 compose files - Removed bind mounts for
docker-entrypoint.sh,wait-storage.sh, andwait-partition.sh - Deleted the TODO comments tracking this temporary workaround
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker/docker-compose.yml | Removes temporary entrypoint overrides and script mounts for the single-node deployment. |
| docker/docker-compose-3pd-3store-3server.yml | Removes temporary entrypoint overrides and script mounts for the 3PD/3Store/3Server deployment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| x-pd-common: &pd-common | ||
| image: hugegraph/pd:${HUGEGRAPH_VERSION:-latest} | ||
| pull_policy: missing | ||
| restart: unless-stopped | ||
| networks: [hg-net] |
There was a problem hiding this comment.
pull_policy: missing + HUGEGRAPH_VERSION:-latest can keep using a locally cached (older) image instead of pulling the updated one. Since this PR removes the bind-mounted entrypoints/scripts and now relies on the images to contain the new entrypoint logic, using a cached image can lead to startup/config behavior that no longer matches these compose files. Consider switching the compose defaults to pull_policy: always (or pin HUGEGRAPH_VERSION to a known-good tag and document the required minimum image version).
There was a problem hiding this comment.
pull_policy: missing+HUGEGRAPH_VERSION:-latestcan keep using a locally cached (older) image instead of pulling the updated one. Since this PR removes the bind-mounted entrypoints/scripts and now relies on the images to contain the new entrypoint logic, using a cached image can lead to startup/config behavior that no longer matches these compose files. Consider switching the compose defaults topull_policy: always(or pinHUGEGRAPH_VERSIONto a known-good tag and document the required minimum image version).
I agree the image update behavior should be explicit, but I don’t think switching this file to pull_policy: always is the right move yet.
Right now these three images do not have stable release tags like 1.7.0, so always pulling latest on every docker compose up would make production deployments pick up potentially breaking changes without an explicit upgrade step. For now, I’d prefer to keep pull_policy: missing and document the manual refresh workflow here instead.
If users want to force a refresh, run: (could refer it in #2963)
docker compose pull pd store server
docker compose up -d pd store serverOnce release tags are available for all three images, we can revisit pinning the version and updating the compose defaults accordingly.
imbajin
changed the title
Thanks for the update!! |
Purpose of the PR
Follow-up cleanup for #2952 — removes temporary entrypoint volume mounts from compose files now that updated Docker images have been published to Docker Hub with the new entrypoints baked in.
Main Changes
entrypoint:overrides fromdocker/docker-compose.ymlanddocker/docker-compose-3pd-3store-3server.ymldocker-entrypoint.sh,wait-storage.sh, andwait-partition.shfrom all servicesVerifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - No Need