Skip to content

refactor: default equality operators for statistic file structs #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

refactor: default equality operators for statistic file structs #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions src/iceberg/statistics_file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,7 @@ struct ICEBERG_EXPORT BlobMetadata {
std::unordered_map<std::string, std::string> properties;

/// \brief Compare two BlobMetadatas for equality.
friend bool operator==(const BlobMetadata& lhs, const BlobMetadata& rhs) {
return lhs.type == rhs.type && lhs.source_snapshot_id == rhs.source_snapshot_id &&
lhs.source_snapshot_sequence_number == rhs.source_snapshot_sequence_number &&
lhs.fields == rhs.fields && lhs.properties == rhs.properties;
}
friend bool operator==(const BlobMetadata& lhs, const BlobMetadata& rhs) = default;
};

/// \brief Represents a statistics file in the Puffin format
Expand All @@ -66,12 +62,7 @@ struct ICEBERG_EXPORT StatisticsFile {
std::vector<BlobMetadata> blob_metadata;

/// \brief Compare two StatisticsFiles for equality.
friend bool operator==(const StatisticsFile& lhs, const StatisticsFile& rhs) {
return lhs.snapshot_id == rhs.snapshot_id && lhs.path == rhs.path &&
lhs.file_size_in_bytes == rhs.file_size_in_bytes &&
lhs.file_footer_size_in_bytes == rhs.file_footer_size_in_bytes &&
lhs.blob_metadata == rhs.blob_metadata;
}
friend bool operator==(const StatisticsFile& lhs, const StatisticsFile& rhs) = default;
};

/// \brief Represents a partition statistics file
Expand All @@ -86,10 +77,7 @@ struct ICEBERG_EXPORT PartitionStatisticsFile {

/// \brief Compare two PartitionStatisticsFiles for equality.
friend bool operator==(const PartitionStatisticsFile& lhs,
const PartitionStatisticsFile& rhs) {
return lhs.snapshot_id == rhs.snapshot_id && lhs.path == rhs.path &&
lhs.file_size_in_bytes == rhs.file_size_in_bytes;
}
const PartitionStatisticsFile& rhs) = default;
};

/// \brief Returns a string representation of a BlobMetadata
Expand Down
Loading