refactor: use ICEBERG_CHECK where possible #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will simplify the code and potentially optimize the binary due to the [[unlikely]] attribute in ICEBERG_CHECK.
Collaborator
Author
|
@mapleFU does this make sense to you |
lidavidm
approved these changes
Sep 23, 2025
wgtmac
approved these changes
Sep 24, 2025
mapleFU
approved these changes
Sep 24, 2025
Member
mapleFU
left a comment
mapleFU
left a comment
There was a problem hiding this comment.
This looks good to me, but throw originally might already have internal unlikely in most compilers, so I think it just make code shorter
Collaborator
Author
Fair enough, thanks for the review. |
HuaHuaY
approved these changes
Sep 24, 2025
nullccxsy
approved these changes
Sep 24, 2025
Xuanwo
approved these changes
Sep 24, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will simplify the code and potentially optimize the binary due to the [[unlikely]] attribute in ICEBERG_CHECK.