fix: make static_assert template-dependent in ByteSwap #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
force-pushed
the
bugfixes_new
branch
from
027f379 to
a92b325
Compare
The static_assert(false, ...) in the ByteSwap function template was unconditionally evaluated at template definition time, which could cause compilation failures even when the else branch is never instantiated. Changed to static_assert(sizeof(T) == 0, ...) to make the assertion dependent on the template parameter T. This ensures the assertion only triggers when the else branch is actually instantiated with an unsupported floating-point type size.
shangxinli
force-pushed
the
bugfixes_new
branch
from
a92b325 to
db8e8b7
Compare
wgtmac
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static_assert(false, ...) in the ByteSwap function template was unconditionally evaluated at template definition time, which could cause compilation failures even when the else branch is never instantiated.