feat: add roaring-based position bitmap#595

Merged

wgtmac merged 5 commits intoapache:mainfrom

Mar 25, 2026

Member

wgtmac commented Mar 19, 2026

No description provided.

wgtmac force-pushed the bitmap branch 2 times, most recently from 11497ae to 72b274a Compare

March 20, 2026 15:20

wgtmac marked this pull request as ready for review

March 20, 2026 15:20

wgtmac commented

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.h Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.h Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.h Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Outdated Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/roaring_position_bitmap_test.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/test/resources/64map32bitvals.bin Show resolved Hide resolved

wgtmac added 2 commits

March 24, 2026 10:15


          feat: add roaring-based position bitmap

da281d5


          address comments and polish test

c3d16d8

wgtmac force-pushed the bitmap branch from 83cb8f4 to c3d16d8 Compare

March 24, 2026 02:15

wgtmac commented

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Outdated Show resolved Hide resolved


          fix linter

40e01c0

src/iceberg/deletes/roaring_position_bitmap.cc:196:25 [modernize-use-integer-sign-comparison]
Check warning: src/iceberg/deletes/roaring_position_bitmap.cc:196:25 [modernize-use-integer-sign-comparison]
comparison between 'signed' and 'unsigned' integers

Member Author

wgtmac commented Mar 24, 2026

Thanks @emkornfield for your detailed review! I think I've addressed all your comments. Please let me know what you think.

zhjwpku approved these changes

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.cc Show resolved Hide resolved

emkornfield reviewed

View reviewed changes

src/iceberg/deletes/roaring_position_bitmap.h Outdated Show resolved Hide resolved

emkornfield approved these changes

View reviewed changes

blackmwk approved these changes

View reviewed changes

wgtmac and others added 2 commits

March 25, 2026 21:05


          Update src/iceberg/deletes/roaring_position_bitmap.h

91657d1

Co-authored-by: emkornfield <emkornfield@gmail.com>


          fix precommit

9509e07

Member Author

wgtmac commented Mar 25, 2026

Thanks all for the review!

wgtmac merged commit 133742d into apache:main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet