fix: repair shared package linkage and export scan builder symbols#635
Merged
wgtmac merged 2 commits intoapache:mainfrom May 3, 2026
Merged
fix: repair shared package linkage and export scan builder symbols#635wgtmac merged 2 commits intoapache:mainfrom
wgtmac merged 2 commits intoapache:mainfrom
Conversation
1. Update the shared installation interface to depend on the static nanoarrow target, since vendored libraries are built only as static artifacts(see prepare_fetchcontent). 2. Switch the example build to use shared libraries to surface linkage issues. This revealed that `TableScanBuilder` symbols are not exported. Explicitly export the `TableScanBuilder` template instantiations so that shared-library consumers can successfully link against `Build()`.
wgtmac
approved these changes
May 3, 2026
wgtmac
reviewed
May 3, 2026
|
|
||
| target_link_libraries(demo_example PRIVATE iceberg::iceberg_bundle_static | ||
| iceberg::iceberg_rest_static) | ||
| target_link_libraries(demo_example PRIVATE iceberg::iceberg_bundle_shared |
Member
There was a problem hiding this comment.
The example now unconditionally links iceberg::iceberg_bundle_shared and iceberg::iceberg_rest_shared, but the project default is ICEBERG_BUILD_SHARED=OFF and ICEBERG_BUILD_STATIC=ON. A default static-only install exports only the static targets, so configuring the example against that package fails at CMake generate with missing iceberg::iceberg_bundle_shared.
Collaborator
Author
There was a problem hiding this comment.
I hadn't considered that. Should we set ICEBERG_BUILD_SHARED=ON and ICEBERG_BUILD_STATIC=OFF, or set both ON?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the shared installation interface to depend on the static nanoarrow target, since vendored libraries are built only as static artifacts(see prepare_fetchcontent).
Switch the example build to use shared libraries to surface linkage issues. This revealed that
TableScanBuildersymbols are not exported. Explicitly export theTableScanBuildertemplate instantiations so that shared-library consumers can successfully link againstBuild().