fix: preserve snapshot ID width in UseRef#661
Merged
Conversation
f69c0b7 to
42f0472
Compare
wgtmac
approved these changes
May 20, 2026
Member
wgtmac
left a comment
There was a problem hiding this comment.
Good catch! Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseRef()snapshot IDs asint64_twhile resolving refsINT32_MAX + 42Root Cause
TableScanBuilder::UseRef()copiedSnapshotRef::snapshot_idinto anint32_t, even though snapshot IDs are modeled asint64_tin refs, metadata lookup, and scan context.Testing
uvx cmake --build build --target scan_test -j 8./build/src/iceberg/test/scan_test --gtest_filter=*UseRefPreservesInt64SnapshotIds*./build/src/iceberg/test/scan_testFixes #660