Skip to content
This repository was archived by the owner on Feb 6, 2024. It is now read-only.

Add Impala to config defined docs menu#101

Merged
pvary merged 1 commit intoapache:mainfrom
samredai:impala
Jun 28, 2022
Merged

Add Impala to config defined docs menu#101
pvary merged 1 commit intoapache:mainfrom
samredai:impala

Conversation

@samredai
Copy link
Contributor

The recent iceberg-theme that was merged uses a Hugo config based menu. This adds the external link to the Impala docs. Since logos are no longer being used, this also removes the impala logo image from the repo.

cc: @pvary

@pvary pvary merged commit 22c2ec7 into apache:main Jun 28, 2022
@pvary
Copy link
Contributor

pvary commented Jun 28, 2022

@samredai: Shall we add a Hive menu item as well?

Also this seems off:

{ name = "Presto", url = "../../how-to-release" , weight = 500 },

@samredai
Copy link
Contributor Author

@pvary yes and yes, thanks for catching that! Opening a PR now 👍

@samredai
Copy link
Contributor Author

@pvary with respect to adding Hive, that actually has its own internal page so when hive.md is copied over from the iceberg repo, it will automatically show up as an item in the leftnav. (Set by the menu: main in the front matter)

@pvary
Copy link
Contributor

pvary commented Jun 28, 2022

That's cool.

Maybe a link in the main menu would be good, somewhere between Presto, Trinto and Impala.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments