Adds graphic for time-travel section of splash page#19
Adds graphic for time-travel section of splash page#19rdblue merged 4 commits intoapache:mainfrom samredai:time_travel
Conversation
|
Although I like the intent here, I'm not sure we want to call out "rollback_to_timestamp" as the key use of time travel. I think we should center querying as as of a certain time as "time travel" while rollback is a more of a maintenance procedure. I feel like the graphic kind of implies that the key way to time travel is to rollback the whole table. Also are we sure we want to add in a Spark specific command here? |
|
I have the same reaction as @RussellSpitzer. I like the visualization of snapshots, but I don't consider rollback to be time travel. Rollback alters the state of the table, while time travel actually reads older versions. The trouble here is that there isn't a good SQL demonstration of time travel yet. We've added table names for time travel in 3.2, but we're waiting for Spark 3.3 to get the spark.read.option("as-of-timestamp", System.currentTimeMillis() - ONE_DAY_MS).load("db.table) |
| <ul class="timeline"> | ||
|
|
||
| <!-- Item 1 --> | ||
| <li> |
There was a problem hiding this comment.
Did you intend to use tabs instead of spaces? It makes this harder to read.
|
I'll update it to use the spark line @rdblue provided but to @RussellSpitzer's point about not using a spark specific command. That has me thinking that maybe we should eventually just have SQL everywhere and not specify any engine at all so as not to give the impression that these are fundamentally specific to an engine since these features can be implemented into any engine, even if it hasn't been yet. The question of which engines have yet to implement specific features feels like a distraction from describing what the features actually are. |
|
Changed this to be a termynal example. Does the sentence "Version rollback allows users to quickly correct problems by resetting tables to a good state." still fit in here or is it better to just remove it completely? spark-time-travel.mp4 |
|
I like the sentence about rollback. I'd probably update the heading to "Time travel and rollback" |
|
On the termynal example, I think there are a couple things we can do to improve it. For example, we could first do |
Done! |
|
| <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="scala>">val NOW=System.currentTimeMillis()</span> | ||
| <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="scala>">(spark</span> | ||
| <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="">.read</span> | ||
| <span data-ty="input" data-ty-cursor="▋" data-ty-prompt="">.option("as-of-timestamp", NOW_MS - ONE_DAY_MS)</span> |
There was a problem hiding this comment.
Since this line still wraps, is it possible to make a constant above? It would be better to wrap the val NOW line:
scala> val TUESDAY = System.currentTimeMillis() - ONE_DAY_MS;
scala> ...
>.option("as-of-timestamp", TUESDAY)
>...We could call it something specific but short (Tuesday works for me) or we could call it YESTERDAY?
There was a problem hiding this comment.
Oh, this also fixes the slight problem that you used NOW and NOW_MS


This adds a timeline graphic for the Time Travel section feature description on the splash page.