feat(table): reject AddDataFiles on v3 when first_row_id is missing (#1000)#1101
Merged
laskoviymishka merged 1 commit intoMay 21, 2026
Conversation
Contributor
Author
|
@laskoviymishka can you please review it? |
zeroshade
approved these changes
May 20, 2026
Member
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
LGTM and narrowly scoped. I'll wait for @laskoviymishka to take a look before merging as I haven't dug into the pyiceberg behavior on this to make sure we're matching
Contributor
Author
|
@laskoviymishka could you please review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1000
When users call
AddDataFiles(orReplaceDataFilesWithDataFiles/ReplaceFiles) with externally-written parquet files on a v3 table, reject the operation iffirst_row_idis not set. This mirrorspyiceberg's behavior — the library cannot fabricate row IDs retroactively, so callers must supply them explicitly via
DataFileBuilder.FirstRowID().Changes
validateDataFilesToAddto requirefirst_row_idon format version >= 3DataFileBuilder.FirstRowID()