fix(test): TestCreateTable existence check failure#1105
Merged
zeroshade merged 2 commits intoMay 21, 2026
Conversation
…amed table PR apache#355 renamed the table created in TestCreateTable from "test-table" to "test-create-table" but left the follow-up CheckTableExists and DropTable calls pointing at the old name. CheckTableExists returns false, s.True(exists) fails, the actual table is never dropped, and the orphan in the namespace cascades into failures for every other suite test via ensureNamespace.
nssalian
approved these changes
May 20, 2026
Contributor
|
Thanks @laskoviymishka. lgtm pending integration tests passing here |
PR apache#355 set expectedLocation to ".../test-write-commit-table" but the table is still created as "test-table-2", so s.Equal(expectedLocation, tbl.Location()) fails. Align the table name with the descriptive expectedLocation, which is what the rest of the refactor was doing.
laskoviymishka
changed the title
dhananjaykrutika
approved these changes
May 21, 2026
zeroshade
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #355 renamed the table created in TestCreateTable from "test-table" to "test-create-table" but left the follow-up CheckTableExists and DropTable calls pointing at the old name. CheckTableExists returns false, s.True(exists) fails, the actual table is never dropped, and the orphan in the namespace cascades into failures for every other suite test via ensureNamespace.