fix(table): restore Summary/ColumnSizes test expectations to arrow-go v18.6.0#1114
Merged
Merged
Conversation
… v18.6.0 PR apache#1102 ("fix(manifest): stop writing deprecated distinct_counts") also lowered the expected `added-files-size`, `removed-files-size`, `total-files-size`, and ColumnSizes byte counts in `TestTableWriting/{TestAddFilesUnpartitioned,TestAddFilesPartitionedTable, TestReplaceDataFiles}` and `TestPositionDeletePartitionedFanoutWriterProcessBatch`. The new values only reproduce against an unreleased arrow-go build; against the pinned `arrow-go v18.6.0` from go.sum (which every CI matrix entry resolves to) the parquet writer emits the larger byte counts, so the assertions fail on every Linux/macOS/Windows × Go 1.25.5/1.26.1 job since apache#1102 landed. The `distinct_counts` removal in apache#1102 only changes manifest entry serialization, not the data parquet files whose sizes those Summary and ColumnSizes fields tally, so the test-only revert restores green CI without touching production code. Verified locally with `GOWORK=off go test ./...` (forces use of pinned v18.6.0 dependency, mirroring CI): - before: TestTableWriting and TestPositionDeletePartitionedFanoutWriter ProcessBatch fail with the same expected/actual diffs as CI - after: all packages pass clean
laskoviymishka
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores main CI to green by reverting only the test-expectation byte counts that #1102 ("fix(manifest): stop writing deprecated distinct_counts") inadvertently changed.
What broke
After #1102 merged to main, both the
GoandAudit and Verifyworkflows started failing on every push, across all 6 matrix entries (ubuntu/windows/macos × Go 1.25.5/1.26.1):with diffs like:
Root cause
These two test files assert on exact byte counts of the on-disk parquet files written by
arrow-go. Those byte counts depend on the parquet writer's metadata encoding, which differs across arrow-go versions.#1102 lowered the expected counts (3590→3070, 1066→963, 1816→2132+→1816, 4264→3687, 88→86, 174→172, 96→94, 187→185). Those new values only reproduce against an unreleased arrow-go build (presumably wired in via a local
go.work). Against the pinnedgithub.com/apache/arrow-go/v18 v18.6.0fromgo.sum— which every CI runner resolves — the writer still emits the original larger sizes, so the assertions fail every time.The PR's own CI runs were
CANCELLEDbefore completion, so this didn't surface at merge time.The functional change in #1102 (dropping
distinct_countsfield-id 111 from the manifest entry Avro schema) only alters manifest serialization, not the data parquet files whose sizes theseSummary/ColumnSizesfields tally — so the test-value updates were always unrelated to the production fix and can be safely reverted on their own.Fix
Revert only the eight byte-count lines back to the pre-#1102 values verified via
git show 51b3140^:table/table_test.go:549,554TestAddFilesUnpartitionedadded-/total-files-sizetable/table_test.go:770,776TestAddFilesPartitionedTableadded-/total-files-sizetable/table_test.go:1136,1140,1144TestReplaceDataFilesadded-/removed-/total-files-sizetable/pos_delete_partitioned_fanout_writer_test.go:77successColumnSizestable/pos_delete_partitioned_fanout_writer_test.go:87batch_with_records_having_different_file_pathsColumnSizesNo production code changes — #1102's manifest fix is preserved intact.
Verification
Reproduced CI failure locally with
GOWORK=off go test ./...(forces use of pinned v18.6.0):okacross every package —iceberg-go,catalog/{glue,hadoop,hive,rest,sql},cmd/iceberg,codec,config,internal,io,io/gocloud,puffin,table,table/{compaction,dv,internal,substrait},view,view/internal.go vet ./...clean,go build ./...clean, LSP diagnostics clean on both touched files.Followup (out of scope)
These tests are inherently brittle — they'll keep breaking on every arrow-go bump that nudges parquet metadata encoding. A future cleanup could replace exact byte assertions with bounds (
> 0, monotonic relationships between added/removed/total) or assert on row counts only. Not addressing here to keep the diff minimal and unblock main.