fix(gocloud): parse gcs.usejsonapi as boolean#1377
Merged
Conversation
zeroshade
approved these changes
Jul 4, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM. Parsing gcs.usejsonapi via strconv.ParseBool preserves the disabled-by-default behavior and matches how other boolean properties are handled; tests cover unset/true/false/invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseGCSConfigused to enable JSON reads ongcs.usejsonapiwhenever the key existed, so values like"false"still switched it on.This change now parses the property as a boolean using
strconv.ParseBooland only enables JSON reads when it resolves totrue.Also included:
true,false, absent, and invalid values (not-a-bool).website/src/configuration.md.io/config.gothat implied truthy-by-presence behavior.Validation
go test ./io/gocloud -run TestParseGCSConfigUseJSONAPI -count=1