fix(requirements): validate missing last partition spec id#1380
Merged
zeroshade merged 1 commit intoJul 4, 2026
Merged
Conversation
zeroshade
approved these changes
Jul 4, 2026
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM. The nil LastPartitionSpecID case now returns a requirement failure instead of panicking, consistent with the other requirement validators, and the tests cover missing/match/mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a panic in requirement validation when metadata lacks last partition spec ID (for example v1 or malformed metadata).
The previous implementation directly dereferenced
meta.LastPartitionSpecID()and could panic. This change now checks for nil and returns a clean requirement failure message:requirement failed: last assigned partition id is missingWhen the field is present, behavior is unchanged and the previous comparison path still validates for mismatches.
Testing
go test ./table -run TestAssertLastAssignedPartitionIDValidate -count=1