fix(types): safe compare defaults in NestedField.Equals#1383
Merged
zeroshade merged 1 commit intoJul 4, 2026
Merged
Conversation
fallintoplace
force-pushed
the
fix/nestedfield-equals-safe-defaults
branch
from
a3d900b to
be1925e
Compare
fallintoplace
force-pushed
the
fix/nestedfield-equals-safe-defaults
branch
from
be1925e to
b9170fe
Compare
zeroshade
approved these changes
Jul 4, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
LGTM. Switching to reflect.DeepEqual makes NestedField.Equals panic-safe for non-comparable defaults while preserving raw-value equality; the non-comparable-defaults test covers it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NestedField.EqualscomparedInitialDefaultandWriteDefaultwith==, which can panic when defaults contain non-comparable values (maps/slices/etc).This changes equality to use
reflect.DeepEqualfor defaults so schema/field comparisons stay safe and correct with nested defaults.Also adds a regression test that verifies:
Equals, andTesting
go test ./... -run 'TestNestedFieldEqualsWithNonComparableDefaults|TestUnknownTypeInNestedStructs|TestTypesBasic' -count=1