Closed
Conversation
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
laskoviymishka
suggested changes
Jul 27, 2025
Contributor
laskoviymishka
left a comment
laskoviymishka
left a comment
There was a problem hiding this comment.
Is this generated by LLM?
If so - be vocal about it, see guidelines
| // action adds two data files with partition data (2021, 1) and (2021, 2), then all existing | ||
| // data files that contain records where year=2021 and month=1 OR year=2021 and month=2 | ||
| // will be replaced. | ||
| type ReplacePartitions interface { |
Contributor
There was a problem hiding this comment.
this and all other PR-s looks like a 1-1 adaptation for java iceberg interfaces
this approach is not really work with golang, it's not ideomatic.
Better to stick with what we have with for example snapshot
No need to define interface just for the sake of interface.
Member
|
ASF guidelines prohibit entirely AI generated PRs. You can use an LLM to assist you, but cannot submit a PR that is entirely AI generated. As such I'm going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a go implementation
replace partitionfeature.cc @laskoviymishka @zeroshade