Skip to content

fix(table): handle race for key map getter #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeroshade merged 1 commit into from
Jan 26, 2026
Merged

fix(table): handle race for key map getter #699

zeroshade merged 1 commit into from
Jan 26, 2026

Conversation

@ferhatelmas
Copy link
Contributor

@ferhatelmas ferhatelmas commented Jan 25, 2026 •
edited
Loading

  • wasted resources (unnecessary calls to factory)
  • references can be different between goroutines that could cause inconsistency
  • if factory has side effects, it might happen multiple times

@ferhatelmas
fix(table): handle race for key map getter
d070437 
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
zeroshade
zeroshade approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zeroshade zeroshade merged commit 0bd8477 into apache:main Jan 26, 2026
11 checks passed
@ferhatelmas ferhatelmas deleted the key-map-race branch January 26, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ferhatelmas @zeroshade