Added steps in README to run unit tests and integration tests#732
Open
subkanthi wants to merge 2 commits intoapache:mainfrom
Open
Added steps in README to run unit tests and integration tests#732subkanthi wants to merge 2 commits intoapache:mainfrom
subkanthi wants to merge 2 commits intoapache:mainfrom
Conversation
ferhatelmas
reviewed
Feb 16, 2026
Comment on lines
+47
to
+80
| ### Linting | ||
|
|
||
| Run [golangci-lint](https://golangci-lint.run/) (matches CI): | ||
|
|
||
| ```shell | ||
| golangci-lint run --timeout=10m | ||
| ``` | ||
|
|
||
| ### Integration tests | ||
| 1. Start the docker containers using docker compose. | ||
|
|
||
| ```shell | ||
| docker compose -f internal/recipe/docker-compose.yml up -d | ||
| sleep 10 | ||
| docker compose -f internal/recipe/docker-compose.yml exec -T spark-iceberg ipython ./provision.py | ||
| sleep 10 | ||
| ``` | ||
|
|
||
| 2. export the required environment variables. | ||
|
|
||
| ```shell | ||
| export AWS_S3_ENDPOINT=http://$(docker inspect -f '{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}' minio):9000 | ||
| export AWS_REGION=us-east-1 | ||
| export SPARK_CONTAINER_ID=$(docker ps -qf 'name=spark-iceberg') | ||
| export DOCKER_API_VER=$(docker version -f '{{.Server.APIVersion}}') | ||
| ``` | ||
|
|
||
| 3. Run the tests. | ||
| ```shell | ||
| go test -tags=integration -v -run="^TestScanner" ./table | ||
| go test -tags=integration -v ./io | ||
| go test -tags=integration -v -run="^TestRestIntegration$" ./catalog/rest | ||
| go test -tags=integration -v -run="^TestSparkIntegration" ./table | ||
| ``` |
Contributor
There was a problem hiding this comment.
shall we add a makefile to use both in CI and readme?
Otherwise, it might easily get outdated or golangci-lint version might be different, etc.
Member
There was a problem hiding this comment.
I don't think we necessarily need a makefile, a simple shell script would likely be enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added steps in README to run unit tests and integration tests