fix(manifest): handle lifecycle of the decoder in reader#766
Merged
zeroshade merged 1 commit intoapache:mainfrom Mar 2, 2026
Merged
fix(manifest): handle lifecycle of the decoder in reader#766zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
ferhatelmas
changed the title
ferhatelmas
force-pushed
the
manifest-reader-decoder-close
branch
2 times, most recently
from
a660257 to
86a61ce
Compare
ferhatelmas
changed the title
ferhatelmas
changed the title
related to apache#721 * remove premature decoder close in the constructor so that reader can actually read the entries * add explicit close method for resource cleanup * call close in ReadManifest to prevent leak * add zstd codec based regression test Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
ferhatelmas
force-pushed
the
manifest-reader-decoder-close
branch
from
86a61ce to
9c4392c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #721
remove premature decoder close in the constructor so that reader can actually read the entries
add explicit close method for resource cleanup
call close in ReadManifest to prevent leak
add zstd codec based regression test