Skip to content

feat(table): export StructLike and GetPartitionRecord#791

Merged
zeroshade merged 3 commits intoapache:mainfrom
twuebi:tp/export-partition-record
Mar 17, 2026
Merged

feat(table): export StructLike and GetPartitionRecord#791
zeroshade merged 3 commits intoapache:mainfrom
twuebi:tp/export-partition-record

Conversation

@twuebi
Copy link
Contributor

@twuebi twuebi commented Mar 16, 2026

PartitionRecord and GetPartitionRecord are the only way to go from a DataFile to something PartitionToPath accepts. Keeping them unexported forces external consumers to reimplement the same conversion.

Also deduplicates the manual record construction in the pos delete writer.

@zeroshade
Copy link
Member

Doesn't PartitionToPath take an interface? Could we get away with just exporting GetPartitionRecord rather than also exporting the PartitionRecord type directly? It just feels like exporting an implementation detail to me.

@twuebi
Copy link
Contributor Author

twuebi commented Mar 17, 2026

It does take a structLike which is also unexported, what should GetPartitionRecord return then? Thought that returning an unexported type may be a bit awkward

@zeroshade zeroshade changed the title feat(table): export PartitionRecord and GetPartitionRecord feat(table): export StructLike and GetPartitionRecord Mar 17, 2026
@zeroshade zeroshade merged commit 55bdfbf into apache:main Mar 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants