feat(table): export StructLike and GetPartitionRecord#791
Merged
zeroshade merged 3 commits intoapache:mainfrom Mar 17, 2026
Merged
feat(table): export StructLike and GetPartitionRecord#791zeroshade merged 3 commits intoapache:mainfrom
zeroshade merged 3 commits intoapache:mainfrom
Conversation
Member
|
Doesn't PartitionToPath take an interface? Could we get away with just exporting |
Contributor
Author
|
It does take a structLike which is also unexported, what should |
zeroshade
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PartitionRecord and GetPartitionRecord are the only way to go from a DataFile to something PartitionToPath accepts. Keeping them unexported forces external consumers to reimplement the same conversion.
Also deduplicates the manual record construction in the pos delete writer.