feat(catalog): refresh oauth tokens#793
Merged
zeroshade merged 1 commit intoapache:mainfrom Mar 18, 2026
Merged
Conversation
Closed
zeroshade
reviewed
Mar 17, 2026
The rest catalog was using a fixed token for the lifetime of the catalog. We need to refresh the token when the oauth server gives us an expiration. This means the credential fetch needs to move into the roundtripper. Also, since we use the same http client for refreshing and making catalog requests, we add a context key to prevent recursion.
zeroshade
reviewed
Mar 18, 2026
zeroshade
reviewed
Mar 18, 2026
|
|
||
| var capturedAuthHeader string | ||
| mux.HandleFunc("/v1/namespaces", func(w http.ResponseWriter, r *http.Request) { | ||
| capturedAuthHeader = r.Header.Get("Authorization") |
Member
There was a problem hiding this comment.
should we assert the authorization is what we expect here?
Contributor
Author
There was a problem hiding this comment.
we assert it down below, this just captures
zeroshade
changed the title
zeroshade
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest catalog was using a fixed token for the lifetime of the
catalog. We need to refresh the token when the oauth server gives us an
expiration. This means the credential fetch needs to move into the
roundtripper. Also, since we use the same http client for refreshing and
making catalog requests, we add a context key to prevent recursion.
Fixes: #794