feat(rest): add audience and resource params to OAuth requests#815
Open
lovromazgon wants to merge 1 commit intoapache:mainfrom
Open
feat(rest): add audience and resource params to OAuth requests#815lovromazgon wants to merge 1 commit intoapache:mainfrom
lovromazgon wants to merge 1 commit intoapache:mainfrom
Conversation
The Iceberg REST spec allows audience and resource as OAuth token request parameters. Wire these through via WithAudience/WithResource options and clientcredentials.Config.EndpointParams
zeroshade
requested changes
Mar 27, 2026
Comment on lines
+118
to
+128
| func WithAudience(audience string) Option { | ||
| return func(o *options) { | ||
| o.audience = audience | ||
| } | ||
| } | ||
|
|
||
| func WithResource(resource string) Option { | ||
| return func(o *options) { | ||
| o.resource = resource | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Just add some docstring comments for these please. Otherwise this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithAudienceandWithResourceoptions to the REST catalog clientTestScopeinto a table-drivenTestOAuthTokenRequestParamscovering scope, audience, and resource combinations