perf(table): Add optional skip duplicate check on AddDataFiles#901
Merged
zeroshade merged 1 commit intoApr 15, 2026
Merged
Conversation
zeroshade
approved these changes
Apr 15, 2026
Member
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddDataFiles unconditionally scans every manifest in the current snapshot to check whether any file being added already exists in the table. Each manifest requires a storage read (e.g. an S3 GET). For tables with many commits and manifests this means hundreds of sequential reads, easily pushing the operation past reasonable processing time.
AddFiles method already has an ignoreDuplicates parameter that skips this scan, but AddDataFiles has no equivalent.
WithoutDuplicateCheck() fills this gap. Callers who can guarantee the files being added are new (e.g. freshly written by a compaction job or an ingestion pipeline with unique naming) can opt out of the scan and avoid the I/O cost entirely.