fix(rest): making non 200 rest errors more informative#972
Merged
Conversation
Signed-off-by: happydave1 <dzhao2004@gmail.com>
laskoviymishka
requested changes
May 3, 2026
Contributor
laskoviymishka
left a comment
There was a problem hiding this comment.
Direction looks right, and handling the flat S3 Tables {"message":"..."} body makes sense.
I’d request changes before merging though, mainly because this is an error-decoding edge case and currently has no tests. At minimum, please add coverage for:
- flat
{"message":"x"}preserving the status sentinel viaerrors.Is - canonical
{"error":{"message":"x","type":"y"}}still rendering as expected - empty body / HEAD falling back to the wrapped status error instead of
": " - the new
Error()formatting branches
One small code concern too: the new Code field is decoded but never used. Either include it in the rendered error, or drop it.
Also, e = *payload.Error feels a bit fragile. It would be safer to keep decoding into &e as before and only fill the flat fields when there is no useful nested error.
Signed-off-by: happydave1 <dzhao2004@gmail.com>
Signed-off-by: happydave1 <dzhao2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #971