-
Notifications
You must be signed in to change notification settings - Fork 388
Make UnaryPredicate JSON Serializable and Add Unit Tests #2598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make UnaryPredicate JSON Serializable and Add Unit Tests #2598
Conversation
ad99ec8 to
9d333ee
Compare
|
@Fokko please review these changes , when you get a chance. |
4096627 to
9c9b3c4
Compare
Co-authored-by: Fokko Driesprong <fokko@apache.org>
|
@Fokko While testing locally, I’m getting 15 test failures, but in the CI check, there’s only 1 test failing. Could you please help me understand what might be causing this difference? |
|
@Aniketsy Sure thing, I'm happy to. Could you share the output of the console? |
|
sure, |
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @Aniketsy! This looks good to me 👍
|
@Fokko Thanks! |
#2522
This PR makes the
UnaryPredicateclass and its subclasses (IsNull,NotNull,IsNaN,NotNaN) JSON serializable using PydanticPlease let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !