Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Oct 17, 2025

test_not_equal_to_invert should test unbound References,

Bound one are tested here:

def test_bound_not_equal_to_invert(table_schema_simple: Schema) -> None:
bound = BoundNotEqualTo(
BoundReference(table_schema_simple.find_field(1), table_schema_simple.accessor_for_field(1)), literal("hello")
)
assert ~bound == BoundEqualTo(
term=BoundReference(
field=NestedField(field_id=1, name="foo", field_type=StringType(), required=False),
accessor=Accessor(position=0, inner=None),
),
literal=literal("hello"),
)

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fokko Fokko merged commit 9bff326 into apache:main Oct 17, 2025
10 checks passed
@Fokko Fokko deleted the fd-fix-faulty-tests branch October 17, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants