feat: Make AND expression JSON serializable #2784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@geruh Thanks a lot for getting the tests to pass and moving this forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2518, #2775
Rationale for this change
This work was done by @Aniketsy, I just opened this to get the tests passing, and we can merge for scan planning.
But, this PR allows
Andexpressions to be deserialized from JSON through Pydantic.This PR aligns the
Andexpression with theOr/Notpattern by addingIcebergBaseModelas an inherited class. This gets teh And expression into a proven serializable state, preparing it for the full expression tree [de]serializability work in #2783.Are these changes tested?
Yes added a test and ensure that they align with EpressionParser in Iceberg Java
Are there any user-facing changes?
No this is just serialization
cc: @kevinjqliu @Fokko