fix: show helpful error when hive catalog config is missing uri#3077
Open
jx2lee wants to merge 2 commits intoapache:mainfrom
Open
fix: show helpful error when hive catalog config is missing uri#3077jx2lee wants to merge 2 commits intoapache:mainfrom
jx2lee wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3069
Rationale for this change
When a catalog is explicitly configured with
type: hivebuturiis missing in.pyiceberg.yaml,the CLI currently fails with a raw
KeyError('uri'), which is surfaced as just:'uri'❯ cat .pyiceberg.yaml catalog: my_hive_catalog: type: hive warehouse: warehouse_loc ❯ uv run pyiceberg --catalog my_hive_catalog list 'uri'It's confusing for users because the command appears to return an identifier-like value instead of
a configuration error.
This change adds explicit validation for required catalog properties when the catalog type is already
specified (e.g.
hive,rest,sql), so users get a clear actionable error message instead.Are these changes tested?
Yes.
--catalog <name> listwithtype: hiveand missinguriURI missing...message and no longer prints'uri'Are there any user-facing changes?
Yes.
Users now see a clear error message (for example):
URI missing, please provide using --uri, the config or environment variable PYICEBERG_CATALOG__<CATALOG_NAME>__URIinstead of a raw
'uri'error whentype: hiveis configured withouturi.