feat: Add support for writing bloom filters#3265
Draft
renaudb wants to merge 2 commits intoapache:mainfrom
Draft
feat: Add support for writing bloom filters#3265renaudb wants to merge 2 commits intoapache:mainfrom
renaudb wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #850
Note: This PR is currently held back by boto requiring
pyarrow<=23.1as bloom filter write support was added in pyarrow 24.Rationale for this change
Add support for writing bloom filters to parquet files. This changes leverages the new
bloom_filter_optionswrite_parquetargument in pyarrow 24.Are these changes tested?
Added tests for the metadata parsing. Added a very basic test for the writing path (there is currently no way to test for the existence of a bloomfilter in a parquet file using pyarrow).
Are there any user-facing changes?
N/A