Add override annotations to catalog and file IO implementations#3359
Open
adminlip wants to merge 1 commit into
Open
Add override annotations to catalog and file IO implementations#3359adminlip wants to merge 1 commit into
adminlip wants to merge 1 commit into
Conversation
Contributor
|
Thanks a lot for this PR! It looks like this method is only supported in Python 3.12+. We're still supporting 3.10 + 3.11, so I don't think we can merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
typing.overrideannotations to concrete catalog and file IO implementations so overridden base-class methods are explicit and can be checked by type tooling on supported Python versions. The change covers the SQL catalog methods and the PyArrow/Fsspec file implementations referenced in the issue while keeping the diff limited to those implementation files.Closes #1310