ci: Migrate to uv for python #1796
Merged
+811
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Before 
After 
|
Signed-off-by: Xuanwo <github@xuanwo.io>
kevinjqliu
approved these changes
Oct 28, 2025
| name = "pyiceberg-core" | ||
| readme = "project-description.md" | ||
| requires-python = "~=3.9" | ||
| requires-python = ">=3.10,<3.13" |
There was a problem hiding this comment.
Suggested change
| requires-python = ">=3.10,<3.13" | |
| requires-python = ">=3.10" |
nit: do we have to use upperbound?
| "maturin>=1.0,<2.0", | ||
| "pytest>=8.3.2", | ||
| "datafusion==50.*", | ||
| "pyiceberg[sql-sqlite,pyarrow] @ git+https://github.com/apache/iceberg-python.git@d3eb149fe99b14e714a06e727b69cd617c6c052d", |
There was a problem hiding this comment.
why are we using this specific commit?
Comment on lines
+89
to
+92
| - name: Install uv | ||
| shell: bash | ||
| run: | | ||
| python -m pip install uv==0.9.3 |
There was a problem hiding this comment.
Suggested change
| - name: Install uv | |
| shell: bash | |
| run: | | |
| python -m pip install uv==0.9.3 | |
| - name: Install uv | |
| uses: astral-sh/setup-uv@v6 | |
| with: | |
| version: "0.9.3" |
nit: recommend to use the setup-uv action, https://docs.astral.sh/uv/guides/integration/github/#installation
kevinjqliu
reviewed
Oct 28, 2025
Comment on lines
+35
to
+47
| uv sync --group dev | ||
| ``` | ||
|
|
||
| ## Build | ||
|
|
||
| ```shell | ||
| hatch run dev:develop | ||
| uv run --group dev maturin develop | ||
| ``` | ||
|
|
||
| ## Test | ||
|
|
||
| ```shell | ||
| hatch run dev:test | ||
| uv run --group dev pytest |
There was a problem hiding this comment.
I think it would be helpful to add these into a Makefile
|
uv rocks! |
Xuanwo
pushed a commit
that referenced
this pull request
Oct 29, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> Follow up to #1796 This PR adds ``` make install make build make test ``` to `bindings/python/` ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Migrate to uv
Are these changes tested?