Skip to content

refactor: Remove redundant parameters from SnapshotProducer validation methods #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liurenjie1024 merged 1 commit into from
Nov 13, 2025
Merged

refactor: Remove redundant parameters from SnapshotProducer validation methods #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/iceberg/src/transaction/append.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,11 @@ impl TransactionAction for FastAppendAction {
);

// validate added files
snapshot_producer.validate_added_data_files(&self.added_data_files)?;
snapshot_producer.validate_added_data_files()?;

// Checks duplicate files
if self.check_duplicate {
snapshot_producer
.validate_duplicate_files(&self.added_data_files)
.await?;
snapshot_producer.validate_duplicate_files().await?;
}

snapshot_producer
Expand Down
12 changes: 5 additions & 7 deletions crates/iceberg/src/transaction/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ impl<'a> SnapshotProducer<'a> {
}
}

pub(crate) fn validate_added_data_files(&self, added_data_files: &[DataFile]) -> Result<()> {
for data_file in added_data_files {
pub(crate) fn validate_added_data_files(&self) -> Result<()> {
for data_file in &self.added_data_files {
if data_file.content_type() != crate::spec::DataContentType::Data {
return Err(Error::new(
ErrorKind::DataInvalid,
Expand All @@ -123,11 +123,9 @@ impl<'a> SnapshotProducer<'a> {
Ok(())
}

pub(crate) async fn validate_duplicate_files(
&self,
added_data_files: &[DataFile],
) -> Result<()> {
let new_files: HashSet<&str> = added_data_files
pub(crate) async fn validate_duplicate_files(&self) -> Result<()> {
let new_files: HashSet<&str> = self
.added_data_files
.iter()
.map(|df| df.file_path.as_str())
.collect();
Expand Down
Loading