Raise concurrency errors properly for glue tables #1875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fetch current VersionId from Glue table before commit - Pass version_id to update_table() to enable proper optimistic locking - Prevents concurrent commits from silently overwriting each other - Fixes orphaned files issue when multiple writers commit simultaneously
jembishop
changed the title
jembishop
changed the title
Xuanwo
approved these changes
Nov 19, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
sgrebnov
pushed a commit
to spiceai/iceberg-rust
that referenced
this pull request
Nov 29, 2025
## Which issue does this PR close? apache#1868 ## What changes are included in this PR? As referenced in the issue, the optimistic concurrency was not working correctly as we need to check the glue table version has not incremented before we make our update, so we can get back the error if there is a concurrent modification. This changes the `update_table` to properly handle this case. Also changed the `load_table` to `load_table_with_version_id`, and `load_table` now just uses that. <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? I have tested them using my specific setup with concurrent writers to iceberg tables in aws glue, but not generically. Writing a test case doesn't seem feasible as one needs a glue table. <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> --------- Co-authored-by: Jem Bishop <jem@lo.tech> # Conflicts: # crates/catalog/glue/src/catalog.rs
sgrebnov
added a commit
to spiceai/iceberg-rust
that referenced
this pull request
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#1868
What changes are included in this PR?
As referenced in the issue, the optimistic concurrency was not working correctly as we need to check the glue table version has not incremented before we make our update, so we can get back the error if there is a concurrent modification.
This changes the
update_tableto properly handle this case.Also changed the
load_tabletoload_table_with_version_id, andload_tablenow just uses that.Are these changes tested?
I have tested them using my specific setup with concurrent writers to iceberg tables in aws glue, but not generically. Writing a test case doesn't seem feasible as one needs a glue table.