feat(rest): Add comprehensive error handling system for REST catalog #1919
+859
−139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Currently we only have a simple
deserialize_unexpected_catalog_errorfunction for errors. Adds a comprehensive error handling system for the REST catalog. Related java implementation is inErrorHandlers.java.Also, I fixed to handle OAuth error response with OAuth-specific error format. OAuth errors currently use a format per RFC 6749:
{ "error": "invalid_client", "error_description": "Client authentication failed" }This differs from standard REST catalog errors which use:
{ "error": { "message": "...", "type": "NoSuchTableException", "code": 404 } }So I parses the OAuth error format and converts it to ErrorResponse format for compatibility with error handlers.
Are these changes tested?
unit test, integration test. Currently the integration test only covers the successful cases. After this PR, the failed cases are added.