perf(reader): Pass data file size and delete file size to reader to avoid stat() calls#2175
Open
mbutrovich wants to merge 5 commits intoapache:mainfrom
Open
perf(reader): Pass data file size and delete file size to reader to avoid stat() calls#2175mbutrovich wants to merge 5 commits intoapache:mainfrom
stat() calls#2175mbutrovich wants to merge 5 commits intoapache:mainfrom
Conversation
mbutrovich
changed the title
FileScanTasks to avoid stat() callFileScanTasks to avoid stat() call
blackmwk
reviewed
Feb 25, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich for this pr!
mbutrovich
changed the title
FileScanTasks to avoid stat() callFileScanTasks to avoid stat() call
mbutrovich
force-pushed
the
file_size_passthrough
branch
from
9fe0cc2 to
f558510
Compare
Collaborator
Author
|
Thanks for the review @blackmwk. Hopefully I addressed your concerns. I went back to the spec, and it requires manifests to have |
mbutrovich
changed the title
FileScanTasks to avoid stat() callstat() call
mbutrovich
changed the title
stat() callstat() calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
stat()is taking over 17% of the CPU time increate_record_batch_stream_builder:What changes are included in this PR?
FileScanTask. Iceberg Java does this by wrapping a reference to aDataFilein itsFileScanTask. In this case we're just cherry-picking some fields until we decide we need more.Are these changes tested?
Existing tests.