Honor parquet compression table properties#2378
Open
mattefunnel wants to merge 1 commit intoapache:mainfrom
Open
Honor parquet compression table properties#2378mattefunnel wants to merge 1 commit intoapache:mainfrom
mattefunnel wants to merge 1 commit intoapache:mainfrom
Conversation
Made-with: Cursor
martin-g
reviewed
Apr 27, 2026
| &self.write_delete_parquet_compression_codec, | ||
| self.write_delete_parquet_compression_level.as_deref(), | ||
| ) | ||
| .unwrap_or(Self::default_parquet_compression()) |
Member
There was a problem hiding this comment.
Shouldn't this fallback to self.write_parquet_compression() as https://github.com/apache/iceberg-rust/pull/2378/changes#diff-b3937e8d5290e685464b83957bdce1758ebe4ce122e25b12edcffd76280582afR247 does ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds typed Parquet compression table properties and uses them for DataFusion writes.
Includes data/delete codec and level resolution, ZSTD fallback for absent or unrecognized values, and DataFusion write tests that inspect Parquet metadata.
Checks: cargo fmt --all; cargo test -p iceberg spec::table_properties::tests; cargo test -p iceberg-datafusion test_iceberg_write_exec_ -- --nocapture; cargo check -p iceberg-datafusion; podman compose -f dev/docker-compose.yaml up -d --build --wait; make nextest; podman compose -f dev/docker-compose.yaml down -v --remove-orphans --timeout 0.
Co-Authored-By: Claude noreply@anthropic.com