feat(encryption/kms): Implement KeyManagementClient for AWS KMS#2466
Draft
hsiang-c wants to merge 2 commits into
Draft
feat(encryption/kms): Implement KeyManagementClient for AWS KMS#2466hsiang-c wants to merge 2 commits into
KeyManagementClient for AWS KMS#2466hsiang-c wants to merge 2 commits into
Conversation
Author
| } | ||
|
|
||
| /// Creates an `AwsKeyManagementClient` from a pre-configured AWS KMS client. | ||
| pub fn new_with_client(kms_client: Client) -> Self { |
Contributor
There was a problem hiding this comment.
Is the idea here that we would configure the Client in the AwsKmsFactory? https://github.com/apache/iceberg/blob/6d8ebbb1033cbda1360b0ab5d21e5706b1dcadce/aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java#L53-L59. We're exposing the Client now as a part of our public API doesn't quite seem right to me?
Contributor
There was a problem hiding this comment.
I wonder if we should introduce the factory first to get an idea for what the right way to construct the KMS is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
KeyManagementClientgenerate_key()AWS KMS API takes aDataKeySpecto specify the length of the data key. To accommodate it, I introduced one morekey_size: AesKeySizeargument to @xanderbailey 's API. I think we need more discussion about it.Are these changes tested?
Yes, unit test.