Cleanup code for max-file-group-size-bytes in Iceberg rewrite files.

[mukund-thakur]

Feature Request / Improvement

max-file-group-size-bytes and MAX_FILE_GROUP_SIZE_BYTES_DEFAULT are present in two places thus can lead to confusion.
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java#L76
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewritePlanner.java#L106

I suggest we keep the configs in RewriteDataFiles as the external facing interface.

Query engine

None

Willingness to contribute

• I can contribute this improvement/feature independently
• I would be willing to contribute this improvement/feature with guidance from the Iceberg community
• I cannot contribute this improvement/feature at this time

[mukund-thakur]

TBH I am now getting confused on where is the right location for this property as all the size related properties are in SizeBasedFileRewritePlanner.

[mukund-thakur]

I think I understand now why it was left at both places. Because of API backward compatibility.
We should mark @depricated now and remove later after a major version release.

[sachinnn99]

I'd like to work on this.