Skip to content

Spark 4.1: Fail fast when a parameter context reaches an Iceberg DDL command #16683

@j1wonpark

Description

@j1wonpark

Feature Request / Improvement

Follow-up to #16626.

IcebergSparkSqlExtensionsParser.parsePlanWithParameters (Spark 4.1) intentionally does not propagate the ParameterContext to the Iceberg parse path, because Iceberg DDL grammars do not accept parameter markers (? / :name).

Today a non-empty parameterContext reaching an Iceberg command is silently ignored. Since that situation would indicate a caller bug rather than a valid query, it would be safer to fail fast (e.g. throw a clear exception) when a non-empty parameterContext is dispatched to an Iceberg command, instead of dropping it silently.

This was raised as a non-blocking review note on #16626 and split out so that PR stays scoped to the binding fix.

Query engine

Spark

Willingness to contribute

  • I can contribute this improvement/feature independently
  • I would be willing to contribute this improvement/feature with guidance from the Iceberg community
  • I cannot contribute this improvement/feature at this time

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions