Skip to content

HadoopStreams is not properly closed in deleteFilter #3144

@velctor

Description

@velctor

I see HadoopStreams is not properly closed in deleteFilter (iceberg 0.11.0 and 0.12.0) when trying to implement row-level delete reading in trino.

In addition, I found a similar problem in #104

org.apache.iceberg.hadoop.HadoopStreams Unclosed input stream created by:
        org.apache.iceberg.hadoop.HadoopStreams$HadoopSeekableInputStream.<init>(HadoopStreams.java:81)
        org.apache.iceberg.hadoop.HadoopStreams.wrap(HadoopStreams.java:56)
        org.apache.iceberg.hadoop.HadoopInputFile.newStream(HadoopInputFile.java:175)
        io.trino.plugin.hive.authentication.NoHdfsAuthentication.doAs(NoHdfsAuthentication.java:23)
        io.trino.plugin.hive.HdfsEnvironment.doAs(HdfsEnvironment.java:98)
        io.trino.plugin.iceberg.HdfsInputFile.newStream(HdfsInputFile.java:60)
        org.apache.iceberg.parquet.ParquetIO$ParquetInputFile.newStream(ParquetIO.java:181)
        org.apache.parquet.hadoop.ParquetFileReader.<init>(ParquetFileReader.java:773)
        org.apache.parquet.hadoop.ParquetFileReader.open(ParquetFileReader.java:657)
        org.apache.iceberg.parquet.ReadConf.newReader(ReadConf.java:218)
        org.apache.iceberg.parquet.ReadConf.<init>(ReadConf.java:74)
        org.apache.iceberg.parquet.ParquetReader.init(ParquetReader.java:66)
        org.apache.iceberg.parquet.ParquetReader.iterator(ParquetReader.java:77)
        org.apache.iceberg.io.CloseableIterable$ConcatCloseableIterable$ConcatCloseableIterator.<init>(CloseableIterable.java:152)
        org.apache.iceberg.io.CloseableIterable$ConcatCloseableIterable$ConcatCloseableIterator.<init>(CloseableIterable.java:143)
        org.apache.iceberg.io.CloseableIterable$ConcatCloseableIterable.iterator(CloseableIterable.java:138)
        org.apache.iceberg.io.CloseableIterable$4$1.<init>(CloseableIterable.java:99)
        org.apache.iceberg.io.CloseableIterable$4.iterator(CloseableIterable.java:98)
        org.apache.iceberg.io.CloseableIterable$4.iterator(CloseableIterable.java:90)
        org.apache.iceberg.relocated.com.google.common.collect.Iterables.addAll(Iterables.java:320)
        org.apache.iceberg.deletes.Deletes.toEqualitySet(Deletes.java:83)
        org.apache.iceberg.data.DeleteFilter.applyEqDeletes(DeleteFilter.java:137)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions