Spark: Improvements around test initialization #10131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Apr 12, 2024
| .enableHiveSupport() | ||
| .getOrCreate(); | ||
|
|
||
| TestBase.sparkContext = JavaSparkContext.fromSparkContext(spark.sparkContext()); |
Contributor
Author
There was a problem hiding this comment.
TestBase.spark is created in the line above, so we should probably configure the spark context appropriately here
nastra
commented
Apr 12, 2024
| }; | ||
| } | ||
|
|
||
| @TempDir protected Path temp; |
Contributor
Author
There was a problem hiding this comment.
there's already a temp variable available in the super class (TestBaseWithCatalog), so we don't need to have 2 different ones
amogh-jahagirdar
approved these changes
Apr 12, 2024
| } | ||
|
|
||
| @TempDir protected File temp; | ||
| @TempDir protected java.nio.file.Path temp; |
Contributor
There was a problem hiding this comment.
Super nit, but while we're doing this: I find it easier to read if we don't use the fully qualified Path name here, rather use the fullly qualified name for the hadoop Path in dropWarehouse.
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.