Combine ManifestReaders into one parameterized class#1099
Merged
danielcweeks merged 1 commit intoapache:masterfrom Jun 9, 2020
Merged
Combine ManifestReaders into one parameterized class#1099danielcweeks merged 1 commit intoapache:masterfrom
danielcweeks merged 1 commit intoapache:masterfrom
Conversation
rdblue
commented
Jun 5, 2020
| throw new UnsupportedOperationException("Cannot write manifest for table version: " + formatVersion); | ||
| } | ||
|
|
||
| static ManifestReader<?> open(ManifestFile manifest, FileIO io) { |
Contributor
Author
There was a problem hiding this comment.
Note that these aren't public.
danielcweeks
reviewed
Jun 9, 2020
Contributor
|
+1 This looks good to me. I would point out that it's confusing in a number of places where it's necessary to distinguish between |
Contributor
Author
|
I'll start renaming |
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors
ManifestReaderandDeleteManifestReaderinto the same parameterized class,ManifestReader<DataFile | DeleteFile>. Using two separate classes didn't match the write side, where there is oneManifestWriterthat is parameterized, and prevented code paths from supporting both data and delete files. For example, a class to merge manifests should be agnostic to the type of manifest, as long as either data or delete manifests are consistently merged.This commit is also included in #1098 because it is required for those changes. I will rebase that commit this is merged first.