Remove thread local objects and use new visitors#1169
Merged
rdsr merged 1 commit intoapache:masterfrom Jul 6, 2020
Merged
Conversation
rdsr
reviewed
Jul 5, 2020
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
Outdated
Show resolved
Hide resolved
jun-he
force-pushed
the
jun/reset-temporary-states
branch
from
f657254 to
0b9a891
Compare
jun-he
changed the title
jun-he
force-pushed
the
jun/reset-temporary-states
branch
from
0b9a891 to
8317b72
Compare
Contributor
|
Looks good to me. What do you think, @rdsr? |
rdblue
approved these changes
Jul 6, 2020
Contributor
|
+1. Looks great now! |
rdsr
approved these changes
Jul 6, 2020
Collaborator
Author
|
Thanks for the review! |
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up the discussion in #1139, this change remove thread local objects and use new visitors to keep the code straightforward.