Fix FileHandle Leak in BaseDataReader for MetadataFiles#1374
Merged
aokolnychyi merged 3 commits intoapache:masterfrom Aug 25, 2020
Merged
Fix FileHandle Leak in BaseDataReader for MetadataFiles#1374aokolnychyi merged 3 commits intoapache:masterfrom
aokolnychyi merged 3 commits intoapache:masterfrom
Conversation
The core issue here was that previously when using CloseableIterable.filter The iterator generated by the wrapped Iterable would be wrapped by a Guava Iterator regardless of the wrapped iterators closable status. This means Calling Filter on an iterable would result in a CloseableIterable which generated incorrectly unclosable Iterators. To fix this we replace the Guava IterablesFilter operation with the FilterIterator class. This properly wraps the underlying closable iterator so that when we generate iterators we still get classes that can close their wrapped implementations.
Member
Author
|
cc @aokolnychyi + @rdblue |
aokolnychyi
reviewed
Aug 24, 2020
api/src/test/java/org/apache/iceberg/io/TestCloseableIterable.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Aug 24, 2020
aokolnychyi
reviewed
Aug 24, 2020
api/src/test/java/org/apache/iceberg/io/TestableCloseableIterable.java
Outdated
Show resolved
Hide resolved
Contributor
|
Looks good to me except formatting nits. |
Member
Author
|
All cleaned up style wise |
Contributor
|
I'd put |
aokolnychyi
approved these changes
Aug 25, 2020
Contributor
|
I've tested locally and it solves the problem in metadata tables. I am merging it. |
parthchandra
pushed a commit
to parthchandra/iceberg
that referenced
this pull request
Oct 22, 2025
Release 1.5.0.5-apple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core issue here was that previously when using CloseableIterable.filter
The iterator generated by the wrapped Iterable would be wrapped by a Guava
Iterator regardless of the wrapped iterators closable status. This means
Calling Filter on an iterable would result in a CloseableIterable which
generated incorrectly unclosable Iterators.
To fix this we replace the Guava IterablesFilter operation with the
FilterIterator class. This properly wraps the underlying closable iterator
so that when we generate iterators we still get classes that can close
their wrapped implementations.