Core: Fix overflow due to default value on timestamp nanos

[ebyhr]

Iceberg throws exceptions if JSON contains default values on timestamp nanos:

Caused by: java.lang.ArithmeticException: long overflow
	at java.base/java.lang.Math.multiplyExact(Math.java:1035)
	at org.apache.iceberg.util.DateTimeUtil.microsToNanos(DateTimeUtil.java:101)
	at org.apache.iceberg.expressions.Literals$TimestampLiteral.to(Literals.java:447)
	at org.apache.iceberg.expressions.Literals$LongLiteral.to(Literals.java:306)
	at org.apache.iceberg.types.Types$NestedField.castDefault(Types.java:890)
	at org.apache.iceberg.types.Types$NestedField.<init>(Types.java:882)
	at org.apache.iceberg.types.Types$NestedField$Builder.build(Types.java:850)
	at org.apache.iceberg.SchemaParser.structFromJson(SchemaParser.java:242)
	at org.apache.iceberg.SchemaParser.typeFromJson(SchemaParser.java:186)
	at org.apache.iceberg.SchemaParser.fromJson(SchemaParser.java:277)
	at org.apache.iceberg.util.JsonUtil.parse(JsonUtil.java:104)
	at org.apache.iceberg.SchemaParser.lambda$fromJson$1(SchemaParser.java:296)
	at com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$doComputeIfAbsent$14(BoundedLocalCache.java:2704)
	at java.base/java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1932)
	at com.github.benmanes.caffeine.cache.BoundedLocalCache.doComputeIfAbsent(BoundedLocalCache.java:2702)
	at com.github.benmanes.caffeine.cache.BoundedLocalCache.computeIfAbsent(BoundedLocalCache.java:2684)
	at com.github.benmanes.caffeine.cache.LocalCache.computeIfAbsent(LocalCache.java:112)
	at com.github.benmanes.caffeine.cache.LocalManualCache.get(LocalManualCache.java:63)
	at org.apache.iceberg.SchemaParser.fromJson(SchemaParser.java:296)

[RussellSpitzer]

This is a problem for 1.10? Should we block the release on this? While I know the chances are unlikely here but if anyone is trying to set defaults close to Epoch they won't Overflow and will instead write incorrect values

[stevenzwu]

should we check value not null? the json value itself can also be null, right?

[RussellSpitzer]

We could precondition this, we will have slightly divergent behavior though. The normal path would bail out here

https://github.com/apache/iceberg/blob/d5476cae1b4e9b560f0126b7b9117630da9a37ca/api/src/main/java/org/apache/iceberg/expressions/Literals.java#L58C6-L61C101

So as written this would throw an NPE at a different spot only for nanos

[stevenzwu]

yes, this is not an issue. the spec says

Non-null values for initial-default or write-default are invalid.

Earlier, I wasn't sure if null values are allowed for the default attributes.

[github-actions]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

[github-actions]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.