API: Add exception definitions for scan planning #14442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
force-pushed
the
add-missing-exceptions-for-scan-planning
branch
from
fc06984 to
7c0a84f
Compare
singhpk234
approved these changes
Oct 30, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @amogh-jahagirdar !
have a minor suggesstion comming the previous error message for table / namespace not found.
api/src/main/java/org/apache/iceberg/exceptions/NoSuchPlanIdException.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/iceberg/exceptions/NoSuchPlanTaskException.java
Show resolved
Hide resolved
api/src/main/java/org/apache/iceberg/exceptions/NoSuchPlanIdException.java
Show resolved
Hide resolved
Co-authored-by: Prashant Singh <35593236+singhpk234@users.noreply.github.com>
huaxingao
approved these changes
Oct 30, 2025
nastra
approved these changes
Oct 30, 2025
Contributor
Author
|
Thanks @singhpk234 @huaxingao @nastra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was working with @singhpk234 on separating out some of the RESTCatalogAdapter changes for supporting scan planning on the server side and noticed we're missing some exception definitions for REST scan planning. Notably, NoSuchPlanTaskException and NoSuchPlanIdException when tasks/plans are fetched for those respectively and they don't actually exist.