Core: Minor code improvements#14489
Merged
Merged
Conversation
singhpk234
approved these changes
Nov 3, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
mostly LGTM, thanks @nastra !
| } catch (UnsupportedEncodingException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| return URLEncoder.encode(string, StandardCharsets.UTF_8); |
Contributor
There was a problem hiding this comment.
minor : now we don't required to wrap UnsupportedEncodingException in RTE ?
Contributor
Author
There was a problem hiding this comment.
correct, because encode doesn't throw on a known charset (passing "UTF-8" as a plain string would throw in case the encoding isn't supported)
Contributor
There was a problem hiding this comment.
Ah I see, nice catch :) !
Contributor
Author
|
thanks for reviewing @singhpk234 |
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.