Hive: Fix HiveViewOperations does not update view query upon alteration

[stuxuhai]

The current implementation of HiveViewOperations's doCommit method correctly updates the view properties and the Iceberg metadata location in the Hive Metastore (HMS) when a view is altered. However, it fails to update the actual SQL query string stored in the HMS.

This bug causes severe inconsistency:

1. A user alters an Iceberg View (e.g., changing the underlying query logic).
2. The Iceberg metadata is updated correctly.
3. The HMS continues to store the old query string, which can lead to users or tools relying on the HMS metadata executing the outdated definition.

This fix guarantees that the view definition in the Hive Metastore is always synchronized with the canonical Iceberg view definition, enhancing compatibility and reliability when using external systems that rely on HMS for query metadata.

[huaxingao]

@stuxuhai Thanks for the PR! Can we add a test?

[stuxuhai]

@huaxingao Thx! Unit test has been added.

[ebyhr]

Could you fix a checkstyle error? You can run:

./gradlew :iceberg-hive-metastore:spotlessApply

[stuxuhai]

@ebyhr thanks，fixed

[nastra]

can you slightly update the test to have

@Test
  public void testViewQueryIsUpdatedOnCommit() throws Exception {
    HiveViewOperations ops = (HiveViewOperations) ((BaseView) view).operations();
    assertThat(view.currentVersion().representations())
        .containsExactly(
            ImmutableSQLViewRepresentation.builder().sql(VIEW_QUERY).dialect("hive").build());

    Table hmsTable = ops.loadHmsTable();
    assertThat(hmsTable.getViewOriginalText()).isEqualTo(VIEW_QUERY);
    assertThat(hmsTable.getViewExpandedText()).isEqualTo(VIEW_QUERY);

    String newQuery = "select * from ns.tbl2 limit 10";
    view =
        catalog
            .buildView(VIEW_IDENTIFIER)
            .withSchema(SCHEMA)
            .withDefaultNamespace(NS)
            .withQuery("hive", newQuery)
            .replace();

    assertThat(view.currentVersion().representations())
        .containsExactly(
            ImmutableSQLViewRepresentation.builder().sql(newQuery).dialect("hive").build());

    Table updatedHmsTable = ops.loadHmsTable();
    assertThat(updatedHmsTable.getViewOriginalText()).isEqualTo(newQuery);
    assertThat(updatedHmsTable.getViewExpandedText()).isEqualTo(newQuery);
  }

[nastra]

LGTM, thanks @stuxuhai

[nastra]

@stuxuhai I've pushed some minor changes to your branch. There's a flaky test that causes CI failures, so please rebase when you get a chance

[stuxuhai]

@nastra Rebased on top of the latest changes. Thanks!