Core: Fix incorrect partition bounds calculation in manifest on deletion #15127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting data files through `DeleteFiles.deleteFromRowFilter`, the manifest file was updated with incorrect partition boundary values if the target table is partitioned by columns of `binary` type. This is mainly because in `PartitionSummary.updateFields`, the update of `PartitionFieldStats`'s min/max field directly references a byte array that could be reused by `ManifestReader` when reading multiple files.
hantangwangd
changed the title
huaxingao
approved these changes
Jan 27, 2026
Contributor
|
@nastra @szehon-ho Would you be interested in taking a quick look at this PR? I’ve approved, but would like one more approval before merging. |
singhpk234
approved these changes
Jan 28, 2026
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM as well, thanks @hantangwangd !
szehon-ho
approved these changes
Jan 28, 2026
Contributor
|
Thanks @hantangwangd for the PR! Thanks @singhpk234 @szehon-ho for the review! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting data files through
DeleteFiles.deleteFromRowFilter, the manifest file was updated with incorrect partition boundary values if the target table is partitioned by columns ofbinarytype.This is mainly because in
PartitionSummary.updateFields, the update ofPartitionFieldStats's min/max field directly references a byte array that could be reused byManifestReaderwhen reading multiple files.This PR fixes it by preventing
PartitionFieldStatsfrom referencing arrays that could be reused and modified. The added test case can stably reproduce this issue.Fix issue #15128